Welcome @goddenrich!

It looks like this is your first PR to kubernetes-client/python-base 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-client/python-base has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.

• If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
• If you signed the CLA as a corporation, please sign in with your organization's credentials at https://identity.linuxfoundation.org/projects/cncf to be authorized.
• If you have done the above and are still having issues with the CLA being reported as unsigned, please log a ticket with the Linux Foundation Helpdesk: https://support.linuxfoundation.org/
• Should you encounter any issues with the Linux Foundation Helpdesk, send a message to the backup e-mail support address at: [email protected]

please sign cla

please sign cla

I did before submitting pr. A little confused why its not showing up. I have signed up with the same email address as used for git commits and my full name. should the name be the username for github (ie. goddenrich)?

Codecov Report

Merging #150 into master will increase coverage by 0.11%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #150      +/-   ##
==========================================
+ Coverage   93.44%   93.56%   +0.11%     
==========================================
  Files          13       13              
  Lines        1374     1384      +10     
==========================================
+ Hits         1284     1295      +11     
+ Misses         90       89       -1

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4f7bcfa...ca007f3. Read the comment docs.

I signed it

/check-cla

@yliaog I have tried everything I can with the CLA. Just raised a ticket at jira.linuxfoundation.org to try to get this resolved

/check-cla

Okay now you're good for the CLA.

thanks. please squash the commits.

/lgtm

I squashed commits and removed some unnecessary spaces. Thanks

/lgtm

/approve

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: goddenrich, yliaog

The full list of commands accepted by this bot can be found here.

The pull request process is described here